lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 129/361] thermal: da9062/61: Prevent hardware access during system suspend
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit 760eea43f8c6d48684f1f34b8a02fddc1456e849 ]

    The workqueue used for monitoring the hardware may run while the device
    is already suspended. Fix this by using the freezable system workqueue
    instead, cfr. commit 51e20d0e3a60cf46 ("thermal: Prevent polling from
    happening during system suspend").

    Fixes: 608567aac3206ae8 ("thermal: da9062/61: Thermal junction temperature monitoring driver")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/thermal/da9062-thermal.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/thermal/da9062-thermal.c
    +++ b/drivers/thermal/da9062-thermal.c
    @@ -106,7 +106,7 @@ static void da9062_thermal_poll_on(struc
    THERMAL_EVENT_UNSPECIFIED);

    delay = msecs_to_jiffies(thermal->zone->passive_delay);
    - schedule_delayed_work(&thermal->work, delay);
    + queue_delayed_work(system_freezable_wq, &thermal->work, delay);
    return;
    }

    @@ -125,7 +125,7 @@ static irqreturn_t da9062_thermal_irq_ha
    struct da9062_thermal *thermal = data;

    disable_irq_nosync(thermal->irq);
    - schedule_delayed_work(&thermal->work, 0);
    + queue_delayed_work(system_freezable_wq, &thermal->work, 0);

    return IRQ_HANDLED;
    }

    \
     
     \ /
      Last update: 2018-11-12 01:09    [W:3.546 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site