lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 166/361] scsi: qla2xxx: Fix recursive mailbox timeout
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Quinn Tran <quinn.tran@cavium.com>

    [ Upstream commit 710bc78f829d014eca95ed7ccc4052bc064b1320 ]

    This patch prevents user space mailbox request from doing chip reset if the
    mailbox timed out. The chip reset is only reserved for the DPC thread to
    ensure all mailbox requests are flushed properly. The DPC thread is
    responsible for the flushing all MBs and chip reset.

    Fixes: b2000805a975 ("scsi: qla2xxx: Flush mailbox commands on chip reset")
    Cc: <stable@ger.kernel.org>
    Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
    Reviewed-by: Ewan D. Milne <emilne@redhat.com>
    Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/qla2xxx/qla_mbx.c
    +++ b/drivers/scsi/qla2xxx/qla_mbx.c
    @@ -493,7 +493,7 @@ qla2x00_mailbox_command(scsi_qla_host_t
    set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags);
    qla2xxx_wake_dpc(vha);
    }
    - } else if (!abort_active) {
    + } else if (current == ha->dpc_thread) {
    /* call abort directly since we are in the DPC thread */
    ql_dbg(ql_dbg_mbx, vha, 0x101d,
    "Timeout, calling abort_isp.\n");

    \
     
     \ /
      Last update: 2018-11-12 01:06    [W:5.210 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site