lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 145/361] RDMA/bnxt_re: Avoid accessing nq->bar_reg_iomem in failure case
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Selvin Xavier <selvin.xavier@broadcom.com>

    [ Upstream commit ed51efd2ce44091a858ad829f666727e7c95695e ]

    In the failure path, nq->bar_reg_iomem gets accessed without
    initializing. Avoid this by calling the bnxt_qplib_nq_stop_irq only if the
    initialization is complete.

    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
    Fixes: 6e04b1035689 ("RDMA/bnxt_re: Fix broken RoCE driver due to recent L2 driver changes")
    Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/hw/bnxt_re/qplib_fp.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
    +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
    @@ -360,7 +360,8 @@ void bnxt_qplib_disable_nq(struct bnxt_q
    }

    /* Make sure the HW is stopped! */
    - bnxt_qplib_nq_stop_irq(nq, true);
    + if (nq->requested)
    + bnxt_qplib_nq_stop_irq(nq, true);

    if (nq->bar_reg_iomem)
    iounmap(nq->bar_reg_iomem);

    \
     
     \ /
      Last update: 2018-11-12 01:05    [W:4.336 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site