lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 219/361] libnvdimm, pmem: Fix badblocks population for raw namespaces
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Williams <dan.j.williams@intel.com>

    commit 91ed7ac444ef749603a95629a5ec483988c4f14b upstream.

    The driver is only initializing bb_res in the devm_memremap_pages()
    paths, but the raw namespace case is passing an uninitialized bb_res to
    nvdimm_badblocks_populate().

    Fixes: e8d513483300 ("memremap: change devm_memremap_pages interface...")
    Cc: <stable@vger.kernel.org>
    Cc: Christoph Hellwig <hch@lst.de>
    Reported-by: Jacek Zloch <jacek.zloch@intel.com>
    Reported-by: Krzysztof Rusocki <krzysztof.rusocki@intel.com>
    Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/nvdimm/pmem.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/nvdimm/pmem.c
    +++ b/drivers/nvdimm/pmem.c
    @@ -421,9 +421,11 @@ static int pmem_attach_disk(struct devic
    addr = devm_memremap_pages(dev, &pmem->pgmap);
    pmem->pfn_flags |= PFN_MAP;
    memcpy(&bb_res, &pmem->pgmap.res, sizeof(bb_res));
    - } else
    + } else {
    addr = devm_memremap(dev, pmem->phys_addr,
    pmem->size, ARCH_MEMREMAP_PMEM);
    + memcpy(&bb_res, &nsio->res, sizeof(bb_res));
    + }

    /*
    * At release time the queue must be frozen before

    \
     
     \ /
      Last update: 2018-11-12 01:01    [W:2.233 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site