lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 221/361] ASoC: sta32x: set ->component pointer in private struct
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Daniel Mack <daniel@zonque.org>

    commit 747df19747bc9752cd40b9cce761e17a033aa5c2 upstream.

    The ESD watchdog code in sta32x_watchdog() dereferences the pointer
    which is never assigned.

    This is a regression from a1be4cead9b950 ("ASoC: sta32x: Convert to direct
    regmap API usage.") which went unnoticed since nobody seems to use that ESD
    workaround.

    Fixes: a1be4cead9b950 ("ASoC: sta32x: Convert to direct regmap API usage.")
    Signed-off-by: Daniel Mack <daniel@zonque.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/codecs/sta32x.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/sound/soc/codecs/sta32x.c
    +++ b/sound/soc/codecs/sta32x.c
    @@ -879,6 +879,9 @@ static int sta32x_probe(struct snd_soc_c
    struct sta32x_priv *sta32x = snd_soc_component_get_drvdata(component);
    struct sta32x_platform_data *pdata = sta32x->pdata;
    int i, ret = 0, thermal = 0;
    +
    + sta32x->component = component;
    +
    ret = regulator_bulk_enable(ARRAY_SIZE(sta32x->supplies),
    sta32x->supplies);
    if (ret != 0) {

    \
     
     \ /
      Last update: 2018-11-12 00:59    [W:4.087 / U:0.692 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site