lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 210/361] usb: gadget: udc: renesas_usb3: Fix b-device mode for "workaround"
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

    commit afc92514a34c7414b28047b1205a6b709103c699 upstream.

    If the "workaround_for_vbus" is true, the driver will not call
    usb_disconnect(). So, since the controller keeps some registers'
    value, the driver doesn't re-enumarate suitable speed after
    the b-device mode is disabled. To fix the issue, this patch
    adds usb_disconnect() calling in renesas_usb3_b_device_write()
    if workaround_for_vbus is true.

    Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the b-device mode")
    Cc: <stable@vger.kernel.org> # v4.14+
    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/udc/renesas_usb3.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/usb/gadget/udc/renesas_usb3.c
    +++ b/drivers/usb/gadget/udc/renesas_usb3.c
    @@ -2437,6 +2437,9 @@ static ssize_t renesas_usb3_b_device_wri
    else
    usb3->forced_b_device = false;

    + if (usb3->workaround_for_vbus)
    + usb3_disconnect(usb3);
    +
    /* Let this driver call usb3_connect() anyway */
    usb3_check_id(usb3);


    \
     
     \ /
      Last update: 2018-11-12 00:59    [W:4.088 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site