lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 082/350] bcache: Populate writeback_rate_minimum attribute
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Peddell <klightspeed@killerwolves.net>

    [ Upstream commit 7567c2a2ad9e80a2ce977eef535e64b61899633e ]

    Forgot to include the maintainers with my first email.

    Somewhere between Michael Lyle's original
    "bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017
    and 1d316e6 bcache: implement PI controller for writeback rate,
    the mapping of the writeback_rate_minimum attribute was dropped.

    Re-add the missing sysfs writeback_rate_minimum attribute mapping to
    "allow the user to specify a minimum rate at which dirty blocks are
    retired."

    Fixes: 1d316e6 ("bcache: implement PI controller for writeback rate")
    Signed-off-by: Ben Peddell <klightspeed@killerwolves.net>
    Signed-off-by: Coly Li <colyli@suse.de>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/md/bcache/sysfs.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/md/bcache/sysfs.c
    +++ b/drivers/md/bcache/sysfs.c
    @@ -263,6 +263,7 @@ STORE(__cached_dev)
    1, WRITEBACK_RATE_UPDATE_SECS_MAX);
    d_strtoul(writeback_rate_i_term_inverse);
    d_strtoul_nonzero(writeback_rate_p_term_inverse);
    + d_strtoul_nonzero(writeback_rate_minimum);

    sysfs_strtoul_clamp(io_error_limit, dc->error_limit, 0, INT_MAX);

    @@ -389,6 +390,7 @@ static struct attribute *bch_cached_dev_
    &sysfs_writeback_rate_update_seconds,
    &sysfs_writeback_rate_i_term_inverse,
    &sysfs_writeback_rate_p_term_inverse,
    + &sysfs_writeback_rate_minimum,
    &sysfs_writeback_rate_debug,
    &sysfs_errors,
    &sysfs_io_error_limit,

    \
     
     \ /
      Last update: 2018-11-12 00:39    [W:3.688 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site