lkml.org 
[lkml]   [2018]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86/fsgsbase/64: Fix the base write helper functions

* Chang S. Bae <chang.seok.bae@intel.com> wrote:

> Factor out the code to change index from the relavant helpers. Now,
> the code is located in do_arch_prctl_64().

typo.

>
> The helper functions that purport to write the base should just write it
> only. It shouldn't have magic optimizations to change the index.
>
> putreg() in ptrace does not write the current task, but a stopped task.
>
> v2: Fix further on the task write functions. Revert the changes on the
> task read helpers.
>
> Suggested-by: Andy Lutomirski <luto@kernel.org>
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>

But most importantly, the changelog is confusing: please start the
changelog with outlining the problem in an easy to digest fashion,
starting with the highest level problem description and then successively
iterating down towards the details.

The title says 'fix' so I suppose this fixes something, it doesn't just
'factor out'?

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-11-01 11:16    [W:0.134 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site