Messages in this thread | | | Date | Thu, 1 Nov 2018 11:14:02 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] kvmclock : convert to SPDX identifiers |
| |
Peng,
On Wed, 31 Oct 2018, Peng Hao wrote:
a few nitpicks upfront. The proper prefix for this is: x86/kvmclock
Most of the time, you can deduce the prefix from running 'git log path/to/file'.
> This patch updates license to use SPDX-License-Identifier > instead of verbose license text
git grep 'This patch' Documentation/process
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn> > --- > arch/x86/kernel/kvmclock.c | 15 +-------------- > 1 files changed, 1 insertions(+), 14 deletions(-) > > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > index 1e67646..0ebd715 100644 > --- a/arch/x86/kernel/kvmclock.c > +++ b/arch/x86/kernel/kvmclock.c > @@ -1,19 +1,6 @@ > +// SPDX-License-Identifier: GPL-2.0
But, this is the wrong tag. The verbose text has:
> - the Free Software Foundation; either version 2 of the License, or > - (at your option) any later version.
So what you want here is: GPL-2.0+ or GPL-2.0-or-later
You really need to be very careful when replacing boiler plate text with SPDX identifiers.
Thanks,
tglx
| |