lkml.org 
[lkml]   [2018]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak
Hello,

On 31/10/2018 19:12:06-0400, Sasha Levin wrote:
> - m->rtc = rtc_device_register(DRIVER_NAME,
> - &m->client->dev,
> - &menelaus_rtc_ops, THIS_MODULE);
> - if (IS_ERR(m->rtc)) {
> + err = rtc_register_device(m->rtc);

This appeared in v4.13, this will not compile on v3.18.

> + if (err) {
> if (alarm) {
> menelaus_remove_irq_work(MENELAUS_RTCALM_IRQ);
> device_init_wakeup(&m->client->dev, 0);
> --
> 2.17.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2018-11-01 01:28    [W:0.186 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site