lkml.org 
[lkml]   [2018]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 105/146] usb: typec: tcpm: Report back negotiated PPS voltage and current
    Date
    From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

    [ Upstream commit 554fab6dbf20ee7298ed2d4e8398b85e6058abb7 ]

    Currently when requesting a specific voltage or current through
    the psy interface, for PPS, when reading back from that interface
    the values will always be the same as previously given, if the
    request was successful. However PPS only allows for 20mV voltage
    steps and 50mA current steps, and the psy class expects microvolt
    and micro amp requests, so inbetween values can be provided through
    this interface. Really when reading back the true values negotiated
    should be given, and not the ones originally asked for.

    To report the actual values negotiated with the Source, the values
    stored are now rounded down to the relevant step units prior to
    building the PPS request, so that those values are later correctly
    reported through the psy interface. In addition this improves the
    adjustments made to meet the operating power requirements of the
    platform, which previously could have been slightly out due to not
    using valid PPS units of voltage and current.

    Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/typec/tcpm.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
    index 4f1f4215f3d6..18fb0433f59a 100644
    --- a/drivers/usb/typec/tcpm.c
    +++ b/drivers/usb/typec/tcpm.c
    @@ -4116,6 +4116,9 @@ static int tcpm_pps_set_op_curr(struct tcpm_port *port, u16 op_curr)
    goto port_unlock;
    }

    + /* Round down operating current to align with PPS valid steps */
    + op_curr = op_curr - (op_curr % RDO_PROG_CURR_MA_STEP);
    +
    reinit_completion(&port->pps_complete);
    port->pps_data.op_curr = op_curr;
    port->pps_status = 0;
    @@ -4169,6 +4172,9 @@ static int tcpm_pps_set_out_volt(struct tcpm_port *port, u16 out_volt)
    goto port_unlock;
    }

    + /* Round down output voltage to align with PPS valid steps */
    + out_volt = out_volt - (out_volt % RDO_PROG_VOLT_MV_STEP);
    +
    reinit_completion(&port->pps_complete);
    port->pps_data.out_volt = out_volt;
    port->pps_status = 0;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-11-01 00:45    [W:4.118 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site