lkml.org 
[lkml]   [2018]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 126/146] coresight: etb10: Fix handling of perf mode
    Date
    From: Suzuki K Poulose <suzuki.poulose@arm.com>

    [ Upstream commit 987d1e8dcd370d96029a3d76a0031b043c4a69ae ]

    If the ETB is already enabled in sysfs mode, the ETB reports
    success even if a perf mode is requested. Fix this by checking
    the requested mode.

    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwtracing/coresight/coresight-etb10.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
    index 306119eaf16a..0dad8626bcfb 100644
    --- a/drivers/hwtracing/coresight/coresight-etb10.c
    +++ b/drivers/hwtracing/coresight/coresight-etb10.c
    @@ -147,6 +147,10 @@ static int etb_enable(struct coresight_device *csdev, u32 mode)
    if (val == CS_MODE_PERF)
    return -EBUSY;

    + /* Don't let perf disturb sysFS sessions */
    + if (val == CS_MODE_SYSFS && mode == CS_MODE_PERF)
    + return -EBUSY;
    +
    /* Nothing to do, the tracer is already enabled. */
    if (val == CS_MODE_SYSFS)
    goto out;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-11-01 00:44    [W:4.311 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site