lkml.org 
[lkml]   [2018]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 47/48] dmaengine: dma-jz4780: Return error if not probed from DT
    Date
    From: Paul Cercueil <paul@crapouillou.net>

    [ Upstream commit 54f919a04cf221bc1601d1193682d4379dacacbd ]

    The driver calls clk_get() with the clock name set to NULL, which means
    that the driver could only work when probed from devicetree. From now
    on, we explicitly require the driver to be probed from devicetree.

    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    Tested-by: Mathieu Malaterre <malat@debian.org>
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/dma-jz4780.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
    index 7373b7a555ec..803cfb4523b0 100644
    --- a/drivers/dma/dma-jz4780.c
    +++ b/drivers/dma/dma-jz4780.c
    @@ -754,6 +754,11 @@ static int jz4780_dma_probe(struct platform_device *pdev)
    struct resource *res;
    int i, ret;

    + if (!dev->of_node) {
    + dev_err(dev, "This driver must be probed from devicetree\n");
    + return -EINVAL;
    + }
    +
    jzdma = devm_kzalloc(dev, sizeof(*jzdma), GFP_KERNEL);
    if (!jzdma)
    return -ENOMEM;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-11-01 00:18    [W:5.585 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site