lkml.org 
[lkml]   [2018]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 4/5] tpm: retrieve digest size of unknown algorithms with PCR read
From
Date
On Thu, 2018-11-01 at 12:02 -0400, Mimi Zohar wrote:
> On Tue, 2018-10-30 at 16:47 +0100, Roberto Sassu wrote:


> > +static int tpm2_init_bank_info(struct tpm_chip *chip,
> > + struct tpm_bank_info *bank)
> > +{
> > + struct tpm_digest digest = {.alg_id = bank->alg_id};
> > + int i;
> > +
> > + for (i = 0; i < ARRAY_SIZE(tpm2_hash_map); i++) {
> > + enum hash_algo crypto_algo = tpm2_hash_map[i].crypto_id;
> > +
> > + if (bank->alg_id != tpm2_hash_map[i].tpm_id)
> > + continue;
> > +
> > + bank->digest_size = hash_digest_size[crypto_algo];
> > + bank->crypto_id = crypto_algo;
> > + return 0;
> > + }
> > +
> > + return tpm2_pcr_read(chip, 0, &digest, &bank->digest_size);

Somewhere there needs to be a check to verify that the returned digest
size is equal to or less than the maximum digest size defined in
tpm_digest structure.

Mimi

\
 
 \ /
  Last update: 2018-11-01 17:24    [W:0.194 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site