Messages in this thread | | | From | Shawn Guo <> | Date | Tue, 9 Oct 2018 18:31:15 +0800 | Subject | Re: [PATCH] phy: inno-usb2-phy: fix off-by-one comparison on port number |
| |
On Tue, Oct 9, 2018 at 6:24 AM Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > Currently the range check on the port index is off-by-one and a potential > out of bounds write can occur on priv->ports[i]. Fix this by checking the > maximum port using >= INNO_PHY_PORT_NUM rather than > INNO_PHY_PORT_NUM. > > Detected by CoverityScan, CID#1466118 ("Out-of-bounds write") > > Fixes: ba8b0ee81fbb ("phy: add inno-usb2-phy driver for hi3798cv200 SoC") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
| |