Messages in this thread | | | From | Sergey Matyukevich <> | Subject | Re: [PATCH] qtnfmac: avoid uninitialized variable access | Date | Tue, 9 Oct 2018 20:25:16 +0000 |
| |
Hello Arnd,
> When qtnf_trans_send_cmd_with_resp() fails, we have not yet initialized > 'resp', as pointed out by a valid gcc warning: > > drivers/net/wireless/quantenna/qtnfmac/commands.c: In function 'qtnf_cmd_send_with_reply': > drivers/net/wireless/quantenna/qtnfmac/commands.c:133:54: error: 'resp' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > Since 'resp_skb' is also not set here, we can skip all further > processing and just print the warning and return the failure code. > > Fixes: c6ed298ffe09 ("qtnfmac: cleanup and unify command error handling") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch! And for reminding me that I forgot to enable gcc warnings in CI builds in addition to sparse checks.
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Regards, Sergey
| |