Messages in this thread | | | Date | Mon, 8 Oct 2018 18:48:11 +0200 | From | Adam Borowski <> | Subject | Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD |
| |
On Mon, Oct 08, 2018 at 03:19:44PM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote: > > A spanking new machine I just got has all but one USB ports wired as 3.0. > > Booting defconfig resulted in no keyboard or mouse, which was pretty > > uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity. > > As 'y' not 'm' -- recovering from initrd problems needs a keyboard. > > > > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > > --- > > arch/x86/configs/x86_64_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > defconfig for x86 actually still works? That's amazing in itself :)
IIRC Gentoo even suggests it in the install instructions (although I haven't looked at Gentoo in quite a while). Other distros have handcrafted approximations of allmodconfig.
> > +CONFIG_USB_XHCI_HCD=y > > CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_OHCI_HCD=y > > You can probably turn ehci and ohci off if you have xhci in the > "default" system now.
Besides mixed wiring (as Alan and Randy mentioned), some machines without USB3 are still usable. I haven't upgraded my home machine in ages -- yet despite it being an ancient Phenom2 x6 it builds defconfig in 6m 13s while this fresh work box in 3m something. Defconfig is supposed to handle a wide range of common hardware, so keeping support for 2011 stuff would be wise.
As for !x86, I see that defconfigs for non-fringe archs already enable XHCI.
Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ 10 people enter a bar: 1 who understands binary, ⢿⡄⠘⠷⠚⠋⠀ 1 who doesn't, D who prefer to write it as hex, ⠈⠳⣄⠀⠀⠀⠀ and 1 who narrowly avoided an off-by-one error.
| |