Messages in this thread | | | Date | Mon, 8 Oct 2018 17:55:50 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 1/3] lib/vsprintf: Prepare for more general use of ptr_to_id() |
| |
On Mon, Oct 08, 2018 at 04:37:29PM +0200, Geert Uytterhoeven wrote: > Hi Andy, > > On Mon, Oct 8, 2018 at 4:25 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Oct 08, 2018 at 01:05:02PM +0200, Geert Uytterhoeven wrote: > > > - Make the ptr argument const, to avoid adding casts in future > > > callers, > > > > > - Add a forward declaration, to avoid moving large blocks of code. > > > > How big it would be? ptr_to_id() itself plus... > > ... all the randomization helpers. > And ptr_to_id() needs pointer_string(), string(), widen_string(), number(), > and move_right(). > > 118 insertions(+), 120 deletions(-) > > Is that acceptable?
Better to ask Peter and others, my personal opinion I would go "forward declaration"-less solution.
-- With Best Regards, Andy Shevchenko
| |