lkml.org 
[lkml]   [2018]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 123/168] net: ena: fix missing calls to READ_ONCE
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Netanel Belgazal <netanel@amazon.com>

    [ Upstream commit 28abf4e9c9201eda5c4d29ea609d07e877b464b8 ]

    Add READ_ONCE calls where necessary (for example when iterating
    over a memory field that gets updated by the hardware).

    Signed-off-by: Netanel Belgazal <netanel@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/amazon/ena/ena_com.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/net/ethernet/amazon/ena/ena_com.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
    @@ -459,7 +459,7 @@ static void ena_com_handle_admin_complet
    cqe = &admin_queue->cq.entries[head_masked];

    /* Go over all the completions */
    - while ((cqe->acq_common_descriptor.flags &
    + while ((READ_ONCE(cqe->acq_common_descriptor.flags) &
    ENA_ADMIN_ACQ_COMMON_DESC_PHASE_MASK) == phase) {
    /* Do not read the rest of the completion entry before the
    * phase bit was validated
    @@ -637,7 +637,7 @@ static u32 ena_com_reg_bar_read32(struct

    mmiowb();
    for (i = 0; i < timeout; i++) {
    - if (read_resp->req_id == mmio_read->seq_num)
    + if (READ_ONCE(read_resp->req_id) == mmio_read->seq_num)
    break;

    udelay(1);
    @@ -1796,8 +1796,8 @@ void ena_com_aenq_intr_handler(struct en
    aenq_common = &aenq_e->aenq_common_desc;

    /* Go over all the events */
    - while ((aenq_common->flags & ENA_ADMIN_AENQ_COMMON_DESC_PHASE_MASK) ==
    - phase) {
    + while ((READ_ONCE(aenq_common->flags) &
    + ENA_ADMIN_AENQ_COMMON_DESC_PHASE_MASK) == phase) {
    pr_debug("AENQ! Group[%x] Syndrom[%x] timestamp: [%llus]\n",
    aenq_common->group, aenq_common->syndrom,
    (u64)aenq_common->timestamp_low +

    \
     
     \ /
      Last update: 2018-10-08 20:58    [W:3.641 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site