lkml.org 
[lkml]   [2018]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks
On Fri, 5 Oct 2018 22:24:26 -0300
Matheus Tavares Bernardino <matheus.bernardino@usp.br> wrote:

> This patch fixes all "Assignment operator '=' should be on the previous
> line" checks found in ad2s1210.c by checkpatch.pl.
>
> Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
Hi Matheus,

Good change, but unfortunately your email client as converted
tabs into spaces so it cannot be applied. Try git am
with this email and you'll see what I mean.
See Documentation/process/email-clients.rst for some hints on this.

Looking forward to V2 with that fixed!

Thanks,

Jonathan
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c
> b/drivers/staging/iio/resolver/ad2s1210.c
> index ac13b99bd9cb..d4b1c2c010f2 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -301,8 +301,8 @@ static ssize_t ad2s1210_store_control(struct device *dev,
> "ad2s1210: write control register fail\n");
> goto error_ret;
> }
> - st->resolution
> - = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> + st->resolution =
> + ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> if (st->pdata->gpioin) {
> data = ad2s1210_read_resolution_pin(st);
> if (data != st->resolution)
> @@ -363,8 +363,8 @@ static ssize_t ad2s1210_store_resolution(struct device *dev,
> dev_err(dev, "ad2s1210: setting resolution fail\n");
> goto error_ret;
> }
> - st->resolution
> - = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> + st->resolution =
> + ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> if (st->pdata->gpioin) {
> data = ad2s1210_read_resolution_pin(st);
> if (data != st->resolution)

\
 
 \ /
  Last update: 2018-10-07 18:42    [W:0.052 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site