lkml.org 
[lkml]   [2018]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] mmc: meson-mx-sdio: mark expected switch fall-through
    In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    where we are expecting to fall through.

    Notice that in this particular case, I replaced the "fall-through:"
    comment with a proper "fall through", which is what GCC is
    expecting to find.

    Addresses-Coverity-ID: 1373880 ("Missing break in switch")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    ---
    drivers/mmc/host/meson-mx-sdio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
    index 2cfec33..abe253c 100644
    --- a/drivers/mmc/host/meson-mx-sdio.c
    +++ b/drivers/mmc/host/meson-mx-sdio.c
    @@ -294,7 +294,7 @@ static void meson_mx_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
    switch (ios->power_mode) {
    case MMC_POWER_OFF:
    vdd = 0;
    - /* fall-through: */
    + /* fall through */
    case MMC_POWER_UP:
    if (!IS_ERR(mmc->supply.vmmc)) {
    host->error = mmc_regulator_set_ocr(mmc,
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-10-05 12:10    [W:2.714 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site