Messages in this thread | | | Date | Thu, 04 Oct 2018 21:53:06 -0700 (PDT) | Subject | Re: [PATCH net] net: dsa: b53: Keep CPU port as tagged in all VLANs | From | David Miller <> |
| |
From: Florian Fainelli <f.fainelli@gmail.com> Date: Thu, 4 Oct 2018 20:24:13 -0700
> Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port > incorrectly") was a bit too trigger happy in removing the CPU port from > the VLAN membership because we rely on DSA to program the CPU port VLAN, > which it does, except it does not bother itself with tagged/untagged and > just usese untagged. > > Having the CPU port "follow" the user ports tagged/untagged is not great > and does not allow for properly differentiating, so keep the CPU port > tagged in all VLANs. > > Reported-by: Gerhard Wiesinger <lists@wiesinger.com> > Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
| |