lkml.org 
[lkml]   [2018]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] staging: rtl8188eu: fix line over 80 characters - style
From
Date
Am 03.10.18 um 23:26 schrieb Joe Perches:
> On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
>> Line break array declaration to clear a 'line over 80 characters'
>> checkpatch warning. For consistency replace 0x0 with 0x00.
> []
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> []
>> @@ -39,7 +39,10 @@ extern unsigned char REALTEK_96B_IE[];
>> /********************************************************
>> MCS rate definitions
>> *********************************************************/
>> -unsigned char MCS_rate_1R[16] = {0xff, 0x00, 0x0, 0x0, 0x01, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0};
>> +unsigned char MCS_rate_1R[16] = {
>> + 0xff, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
>> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
>> +};
>
> Might as well make this const u8.
>
> Here and as well the extern declarations in
> drivers/staging/rtl8188eu/core/rtw_mlme.c
> and
> drivers/staging/rtl8188eu/include/rtw_mlme.h
>
>

I'll send a patch with your suggestions.
Thanks.

Michael

\
 
 \ /
  Last update: 2018-10-04 17:54    [W:0.715 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site