lkml.org 
[lkml]   [2018]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] media: vivid: Support 480p for webcam capture
    I think 480p is a common frame size and it's worth supporting in vivid.
    But, my patch might be ad-hoc. Actually, I'm not sure which values are
    suitable for the intervals.

    We might want to add a more flexible/extensible way to specify frame sizes.
    e.g. passing frame sizes and intervals as module parameters

    Kei

    On Wed, Oct 3, 2018 at 4:06 PM, Keiichi Watanabe <keiichiw@chromium.org> wrote:
    > Support 640x480 as a frame size for video input devices of vivid.
    >
    > Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
    > ---
    > drivers/media/platform/vivid/vivid-vid-cap.c | 5 ++++-
    > 1 file changed, 4 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c b/drivers/media/platform/vivid/vivid-vid-cap.c
    > index 58e14dd1dcd3..da80bf4bc365 100644
    > --- a/drivers/media/platform/vivid/vivid-vid-cap.c
    > +++ b/drivers/media/platform/vivid/vivid-vid-cap.c
    > @@ -51,7 +51,7 @@ static const struct vivid_fmt formats_ovl[] = {
    > };
    >
    > /* The number of discrete webcam framesizes */
    > -#define VIVID_WEBCAM_SIZES 5
    > +#define VIVID_WEBCAM_SIZES 6
    > /* The number of discrete webcam frameintervals */
    > #define VIVID_WEBCAM_IVALS (VIVID_WEBCAM_SIZES * 2)
    >
    > @@ -59,6 +59,7 @@ static const struct vivid_fmt formats_ovl[] = {
    > static const struct v4l2_frmsize_discrete webcam_sizes[VIVID_WEBCAM_SIZES] = {
    > { 320, 180 },
    > { 640, 360 },
    > + { 640, 480 },
    > { 1280, 720 },
    > { 1920, 1080 },
    > { 3840, 2160 },
    > @@ -75,6 +76,8 @@ static const struct v4l2_fract webcam_intervals[VIVID_WEBCAM_IVALS] = {
    > { 1, 5 },
    > { 1, 10 },
    > { 1, 15 },
    > + { 1, 15 },
    > + { 1, 25 },
    > { 1, 25 },
    > { 1, 30 },
    > { 1, 50 },
    > --
    > 2.19.0.605.g01d371f741-goog
    >

    \
     
     \ /
      Last update: 2018-10-03 09:10    [W:2.331 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site