Messages in this thread | | | Date | Mon, 29 Oct 2018 14:46:22 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 4.9 33/98] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties |
| |
On Mon, Oct 29, 2018 at 02:07:52PM +0000, Leonard Crestez wrote: >On 10/25/2018 5:15 PM, Sasha Levin wrote: >> From: Leonard Crestez <leonard.crestez@nxp.com> >> >> [ Upstream commit e6f4292ae0a1e73fae26ced57de13a48f71ad1fa ] >> >> Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same >> register values can be set through the micrel phy driver by using dts >> properties. >> >> This seems preferable and allows cleanly fixing suspend/resume. >> >> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> >> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com> >> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> >> Signed-off-by: David S. Miller <davem@davemloft.net> >> Signed-off-by: Sasha Levin <sashal@kernel.org> > >This patch only fixes suspend on 6ul evk in combination with >79e498a9c7da ("net: phy: micrel: Restore led_mode and clk_sel on >resume"). It is otherwise not very useful to backport just the DT patch. > >That patch was earlier backported but then reverted from 4.9 because it >unexpectedly caused issues when combined with other phy patches applied >out-of-order. It seems a correct fix was eventually made (by backporting >bfe72442578b) and 79e498a9c7da could now be restored: > > https://lkml.org/lkml/2018/7/11/972 > >I'm not sure fixing nfsroot suspend/resume on dev boards meets the >criteria for linux-stable, especially since it already caused trouble >once. In general I'd class "fixing things that never worked before" as >not particularly suitable for backporting.
Thank you for looking into this, I'll drop the patch.
-- Thanks, Sasha
| |