[lkml]   [2018]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH AUTOSEL 4.9 33/98] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties
On Mon, Oct 29, 2018 at 02:07:52PM +0000, Leonard Crestez wrote:
>On 10/25/2018 5:15 PM, Sasha Levin wrote:
>> From: Leonard Crestez <>
>> [ Upstream commit e6f4292ae0a1e73fae26ced57de13a48f71ad1fa ]
>> Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same
>> register values can be set through the micrel phy driver by using dts
>> properties.
>> This seems preferable and allows cleanly fixing suspend/resume.
>> Signed-off-by: Leonard Crestez <>
>> Reviewed-by: Fabio Estevam <>
>> Reviewed-by: Florian Fainelli <>
>> Signed-off-by: David S. Miller <>
>> Signed-off-by: Sasha Levin <>
>This patch only fixes suspend on 6ul evk in combination with
>79e498a9c7da ("net: phy: micrel: Restore led_mode and clk_sel on
>resume"). It is otherwise not very useful to backport just the DT patch.
>That patch was earlier backported but then reverted from 4.9 because it
>unexpectedly caused issues when combined with other phy patches applied
>out-of-order. It seems a correct fix was eventually made (by backporting
>bfe72442578b) and 79e498a9c7da could now be restored:
>I'm not sure fixing nfsroot suspend/resume on dev boards meets the
>criteria for linux-stable, especially since it already caused trouble
>once. In general I'd class "fixing things that never worked before" as
>not particularly suitable for backporting.

Thank you for looking into this, I'll drop the patch.


 \ /
  Last update: 2018-10-29 19:48    [W:0.100 / U:25.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site