lkml.org 
[lkml]   [2018]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 05/14] blk-mq: allow software queue to map to multiple hardware queues
    From
    Date
    On Mon, 2018-10-29 at 10:37 -0600, Jens Axboe wrote:
    > The mapping used to be dependent on just the CPU location, but
    > now it's a tuple of { type, cpu} instead. This is a prep patch
    > for allowing a single software queue to map to multiple hardware
    > queues. No functional changes in this patch.

    A nitpick: mathematicians usually use the { } notation for sets and () for
    tuples. See also https://en.wikipedia.org/wiki/Tuple.

    > + /* wrap */
    > + BUG_ON(!hctx->nr_ctx);

    Another nitpick: how about changing the "wrap" comment into "detect integer
    overflow" or so to make the purpose of the BUG_ON() statement more clear?

    Thanks,

    Bart.

    \
     
     \ /
      Last update: 2018-10-29 18:34    [W:3.879 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site