lkml.org 
[lkml]   [2018]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/9] w1: improve coding style by following strict 80 column line limit
From
Date
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote:
> This satisfies a checkpatch warning

Perhaps run your patches through checkpatch with --strict

> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
[]
> @@ -85,7 +85,8 @@ static void w1_slave_release(struct device *dev)
> sl->master->slave_count--;
> }
>
> -static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf)
> +static ssize_t name_show(struct device *dev,
> + struct device_attribute *attr, char *buf)

atypical alignment.

> []

> @@ -170,7 +173,9 @@ static void w1_netlink_queue_status(struct w1_cb_block *block,
> block->msg->len = 0;
> block->msg->status = (u8)-error;
> if (req_cmd) {
> - struct w1_netlink_cmd *cmd = (struct w1_netlink_cmd *)block->msg->data;
> + struct w1_netlink_cmd *cmd =
> + (struct w1_netlink_cmd *) block->msg->data;

unnecessary space after cast


\
 
 \ /
  Last update: 2018-10-29 00:04    [W:0.093 / U:2.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site