lkml.org 
[lkml]   [2018]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] platform/x86: wmi: declare device_type structure as constant
On Sun, Oct 28, 2018 at 8:07 AM Bhumika Goyal <bhumirks@gmail.com> wrote:
>
> The only usage of device_type structure is getting stored as
> a reference in the type field of device structure. This type
> field is declared const. Therefore, the device_type structure
> can never be modified and can be declared as const.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/platform/x86/wmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 04791ea5d97b..bea35be68706 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -987,19 +987,19 @@ static struct bus_type wmi_bus_type = {
> .remove = wmi_dev_remove,
> };
>
> -static struct device_type wmi_type_event = {
> +static const struct device_type wmi_type_event = {
> .name = "event",
> .groups = wmi_event_groups,
> .release = wmi_dev_release,
> };
>
> -static struct device_type wmi_type_method = {
> +static const struct device_type wmi_type_method = {
> .name = "method",
> .groups = wmi_method_groups,
> .release = wmi_dev_release,
> };
>
> -static struct device_type wmi_type_data = {
> +static const struct device_type wmi_type_data = {
> .name = "data",
> .groups = wmi_data_groups,
> .release = wmi_dev_release,
> --
> 2.14.5
>


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-10-29 14:50    [W:0.039 / U:2.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site