lkml.org 
[lkml]   [2018]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3 3/5] misc/pvpanic: add MMIO support
On Mon, Oct 29, 2018 at 5:22 AM Peng Hao <peng.hao2@zte.com.cn> wrote:
>
> On some architectures (e.g. arm64), it's preferable to use MMIO, since
> this can be used standalone. Add MMIO support to the pvpanic driver.

> pvpanic_walk_resources(struct acpi_resource *res, void *context)
> {
> + struct acpi_resource_fixed_memory32 *fixmem32;
> +
> switch (res->type) {
> case ACPI_RESOURCE_TYPE_END_TAG:
> return AE_OK;
>
> case ACPI_RESOURCE_TYPE_IO:
> - port = res->data.io.minimum;
> + base = (void __iomem *) ioport_map(res->data.io.minimum, 1);
> + return AE_OK;
> +
> + case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
> + fixmem32 = &res->data.fixed_memory32;
> + base = ioremap(fixmem32->address, fixmem32->address_length);
> return AE_OK;

Ouch. Sorry, I forgot to look at this previously.

This should be converted to use
acpi_dev_resource_io()
acpi_dev_resource_memory()

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-10-29 11:31    [W:0.112 / U:12.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site