Messages in this thread | | | Date | Sat, 27 Oct 2018 06:04:45 -0700 | From | Richard Cochran <> | Subject | Re: [PATCH] ptp: drop redundant kasprintf() to create worker name |
| |
On Fri, Oct 26, 2018 at 11:22:59PM +0200, Rasmus Villemoes wrote: > Building with -Wformat-nonliteral, gcc complains > > drivers/ptp/ptp_clock.c: In function ‘ptp_clock_register’: > drivers/ptp/ptp_clock.c:239:26: warning: format not a string literal and no format arguments [-Wformat-nonliteral] > worker_name : info->name); > > kthread_create_worker takes fmt+varargs to set the name of the > worker, and that happens with a vsnprintf() to a stack buffer (that is > then copied into task_comm). So there's no reason not to just pass > "ptp%d", ptp->index to kthread_create_worker() and avoid the > intermediate worker_name variable.
Acked-by: Richard Cochran <richardcochran@gmail.com>
| |