lkml.org 
[lkml]   [2018]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 08/17] thermal: qcom: tsens: enable+check sensor after its setup is finished
On Fri, Oct 26, 2018 at 5:41 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
>
> On Wed, Oct 17, 2018 at 9:24 PM Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > Enable+check sensor after setting tmdev->sensor[i].tzd and calling
> > chipset specific enable operation.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> > drivers/thermal/qcom/tsens.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> > index dbd2556..01bff96 100644
> > --- a/drivers/thermal/qcom/tsens.c
> > +++ b/drivers/thermal/qcom/tsens.c
> > @@ -105,13 +105,13 @@ static int tsens_register(struct tsens_device *tmdev)
> > if (IS_ERR(tzd))
> > continue;
> >
> > - thermal_zone_set_mode(tzd, THERMAL_DEVICE_ENABLED);
> > - thermal_zone_device_check(tzd);
> > -
>
> I don't quite understand why you're making this move explicitly in a
> separate patch for each of the drivers? You added it here in patch 4
> in the first place, why not add it in the correct place there itself?

I think I understand now. You wanted to separate patches causing
functional changes from ones that didn't.

IMHO, it makes the series a bit hard to read but I have no better
suggestion than to squash everything (patches 3-16), but that will
make it harder to collect Acks.

> > tmdev->sensor[i].tzd = tzd;
> >
> > if (tmdev->ops->enable)
> > tmdev->ops->enable(tmdev, i);
> > +
> > + thermal_zone_set_mode(tzd, THERMAL_DEVICE_ENABLED);
> > + thermal_zone_device_check(tzd);
> >
> > }
> > return 0;
> > }
> > --
> > 1.9.1
> >

\
 
 \ /
  Last update: 2018-10-26 14:40    [W:0.051 / U:7.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site