lkml.org 
[lkml]   [2018]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/urgent] perf scripts python: call-graph-from-sql.py: Make a "Main" function
    Commit-ID:  7e4fc93e2ade2b0c453a97e307203ffe3f930c98
    Gitweb: https://git.kernel.org/tip/7e4fc93e2ade2b0c453a97e307203ffe3f930c98
    Author: Adrian Hunter <adrian.hunter@intel.com>
    AuthorDate: Mon, 1 Oct 2018 09:28:39 +0300
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Tue, 23 Oct 2018 14:22:54 -0300

    perf scripts python: call-graph-from-sql.py: Make a "Main" function

    Make a "Main" function so that the variables used do not pollute the global
    namespace.

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Link: http://lkml.kernel.org/r/20181001062853.28285-6-adrian.hunter@intel.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/scripts/python/call-graph-from-sql.py | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/scripts/python/call-graph-from-sql.py b/tools/perf/scripts/python/call-graph-from-sql.py
    index 2e33540f3de0..2b74b94eeccc 100644
    --- a/tools/perf/scripts/python/call-graph-from-sql.py
    +++ b/tools/perf/scripts/python/call-graph-from-sql.py
    @@ -284,7 +284,9 @@ class MainWindow(QMainWindow):

    self.setCentralWidget(self.view)

    -if __name__ == '__main__':
    +# Main
    +
    +def Main():
    if (len(sys.argv) < 2):
    print >> sys.stderr, "Usage is: call-graph-from-sql.py <database name>"
    raise Exception("Too few arguments")
    @@ -331,3 +333,6 @@ if __name__ == '__main__':
    err = app.exec_()
    db.close()
    sys.exit(err)
    +
    +if __name__ == "__main__":
    + Main()
    \
     
     \ /
      Last update: 2018-10-26 09:38    [W:4.083 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site