lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 3.18 36/98] usb: serial: handle -ENODEV quietly in generic_submit_read_urb
    Date
    From: Jeremiah Mahler <jmmahler@gmail.com>

    [ Upstream commit 04f9c6e6d17584340fb6c8a9469a0e6df28876d2 ]

    If a USB serial device (e.g. /dev/ttyUSB0) with an active program is
    unplugged, an -ENODEV (19) error will be produced after it gives up
    trying to resubmit a read.

    usb_serial_generic_submit_read_urb - usb_submit_urb failed: -19

    Add -ENODEV as one of the permanent errors along with -EPERM that
    usb_serial_generic_submit_read_urb() handles quietly without an error.

    Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/serial/generic.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
    index c44b911937e8..54e170dd3dad 100644
    --- a/drivers/usb/serial/generic.c
    +++ b/drivers/usb/serial/generic.c
    @@ -287,7 +287,7 @@ static int usb_serial_generic_submit_read_urb(struct usb_serial_port *port,

    res = usb_submit_urb(port->read_urbs[index], mem_flags);
    if (res) {
    - if (res != -EPERM) {
    + if (res != -EPERM && res != -ENODEV) {
    dev_err(&port->dev,
    "%s - usb_submit_urb failed: %d\n",
    __func__, res);
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-10-25 16:27    [W:4.094 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site