lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/10] sched/fair: Hoist idle_stamp up from idle_balance
From
Date
On 10/25/2018 9:47 AM, Valentin Schneider wrote:
> Hi Steve,
>
> On 22/10/2018 15:59, Steve Sistare wrote:
> [...]
>> @@ -6740,8 +6744,19 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int wake_
>> return p;
>>
>> idle:
>> + /*
>> + * We must set idle_stamp _before_ calling idle_balance(), such that we
>> + * measure the duration of idle_balance() as idle time.
>> + */
>> + IF_SMP(rq->idle_stamp = rq_clock(rq);)
>> +
>> new_tasks = idle_balance(rq, rf);
>>
>> + if (new_tasks)
>> + IF_SMP(rq->idle_stamp = 0;)
>> +
>> + schedstat_end_time(rq->find_time, time);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> That's a stray hunk from 10/10

Thanks Valentin, will fix in next version. I reordered the patches and missed this.

- Steve

\
 
 \ /
  Last update: 2018-10-25 16:06    [W:0.079 / U:9.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site