lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor
  $ git log --oneline --follow drivers/pci/controller/dwc/pci-layerscape.c | head
6e0832fa432e PCI: Collect all native drivers under drivers/pci/controller/
3f43ccc4ea1b PCI: dwc: Remove old MSI IRQs API
8cfab3cf63cf PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate
84d897d69938 PCI: layerscape: Change default error response behavior
a335b122ba27 PCI: layerscape: Add support for ls1012a
03fc6134c260 PCI: layerscape: Add support for ls1088a
8f89357094e6 PCI: layerscape: Add support for ls2088a
c3f909398827 PCI: layerscape: Remove unnecessary class code fixup
e44abfed6fcb PCI: dwc: Add accessors for write permission of DBI read-only registers
4a2745d760fa PCI: layerscape: Disable outbound windows configured by bootloader

Make yours match, e.g., "PCI: layerscape: Call dw_pcie_disable_atu()
correctly"

On Thu, Oct 25, 2018 at 08:53:37AM +0000, Z.q. Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> This issue is introduced by commit 4a2745d760fac ("PCI: layerscape: Disable
> outbound windows configured by bootloader").

Conventional commit reference:

$ git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" 4a2745d760fac
4a2745d760fa ("PCI: layerscape: Disable outbound windows configured by bootloader")

Holy cow, this has been broken since v4.14. If fixing this makes a
difference, you might want to tag it for stable.

> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 69f3f1a5a782..b2085988dbee 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -88,7 +88,7 @@ static void ls_pcie_disable_outbound_atus(struct ls_pcie *pcie)
> int i;
>
> for (i = 0; i < PCIE_IATU_NUM; i++)
> - dw_pcie_disable_atu(pcie->pci, DW_PCIE_REGION_OUTBOUND, i);
> + dw_pcie_disable_atu(pcie->pci, i, DW_PCIE_REGION_OUTBOUND);
> }
>
> static int ls1021_pcie_link_up(struct dw_pcie *pci)
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2018-10-25 15:46    [W:0.066 / U:14.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site