Messages in this thread | | | From | Pascal PAILLET-LME <> | Subject | Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver | Date | Thu, 25 Oct 2018 13:23:08 +0000 |
| |
Hello Mark,
Le 10/24/2018 03:17 PM, Mark Brown a écrit : > On Wed, Oct 24, 2018 at 12:54:46PM +0000, Pascal PAILLET-LME wrote: > >> I'm sorry, I'm not sure to understand. Would you prefer to not register >> regulators that >> are not described in the device-tree ? > No, I'm saying register all regulators regardless of if they are in the > device tree - you shouldn't be looking at the init data at all here, > just let the framework match them using of_match. I have reworked the code so that we don't touch any more to the init_data. the new loop to register the regulators is below:
for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { ret = stpmic1_regulator_register(pdev, i, &stpmic1_matches[i], regul); if (ret < 0) return ret; regul++; }
Each regulator is registered, even is it is not described in the device-tree.
stpmic1_regulator_parse_dt() and stpmic1_regulator_init() are now merged inside stpmic1_regulator_register() function.
Thank You, pascal
| |