lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 6/9] i3c: master: Add driver for Cadence IP
On Wed, 24 Oct 2018 15:25:17 -0500
Grygorii Strashko <grygorii.strashko@ti.com> wrote:

> On 10/24/18 1:20 PM, Boris Brezillon wrote:
> > Hi Arnd,
> >
> > On Mon, 22 Oct 2018 15:34:01 +0200
> > Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> >
> >
> >> +
> >> +static void cdns_i3c_master_rd_from_rx_fifo(struct cdns_i3c_master *master,
> >> + u8 *bytes, int nbytes)
> >> +{
> >> + readsl(master->regs + RX_FIFO, bytes, nbytes / 4);
> >
> > Vitor reported a problem with readsl(): this function expects the 2nd
> > argument to be aligned on 32-bit, which is not guaranteed here. Unless
> > you see a better solution, I'll switch back to a loop doing:
> >
> > for (i = 0; i < nbytes; i += 4) {
> > u32 tmp = __raw_readl(...);
>
> Pls, do not use __raw io.

Except this is exactly what I want here, unless you have a
replacement for "readl() without a mem-barrier and without endianness
conversion"

>
> > memcpy(bytes + i, &tmp,
> > nbytes - i > 4 ? 4 : nbytes - i);
> > }
> >
> >> + if (nbytes & 3) {
> >> + u32 tmp;
> >> +
> >> + readsl(master->regs + RX_FIFO, &tmp, 1);
> >> + memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3);
> >> + }
> >> +}
> >
> > Regards,
> >
> > Boris
> >
>

\
 
 \ /
  Last update: 2018-10-24 23:04    [W:0.101 / U:0.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site