Messages in this thread | | | From | "Z.q. Hou" <> | Subject | RE: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible strings | Date | Thu, 25 Oct 2018 09:27:42 +0000 |
| |
Hi Rob,
Thanks a lot for your comments!
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 2018年10月17日 21:52 > To: Z.q. Hou <zhiqiang.hou@nxp.com> > Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > linux-pci@vger.kernel.org; devicetree@vger.kernel.org; Leo Li > <leoyang.li@nxp.com>; shawnguo@kernel.org; mark.rutland@arm.com; > bhelgaas@google.com; Mingkai Hu <mingkai.hu@nxp.com>; M.h. Lian > <minghuan.lian@nxp.com> > Subject: Re: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible > strings > > On Mon, Oct 08, 2018 at 11:14:25AM +0800, Zhiqiang Hou wrote: > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > > > The pcie compatible string for LS1043A was lost, so add it. > > PCIe > > The subject could be improved to say exactly what compatible string you are > adding. And the subject should start with "dt-bindings: pci: ..." >
Yes, will correct them in v2.
> > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > --- > > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > index 66df1e81e0b8..5eb1c202932f 100644 > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > @@ -18,6 +18,7 @@ Required properties: > > "fsl,ls2088a-pcie" > > "fsl,ls1088a-pcie" > > "fsl,ls1046a-pcie" > > + "fsl,ls1043a-pcie" > > "fsl,ls1012a-pcie" > > - reg: base addresses and lengths of the PCIe controller register blocks. > > - interrupts: A list of interrupt outputs of the controller. Must > > contain an > > -- > > 2.17.1 > >
| |