lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH anybus v1 0/4] Support HMS Profinet Card over Anybus
On Wed, Oct 24, 2018 at 10:24:52AM -0400, Sven Van Asbroeck wrote:
> This patch set adds support for the HMS Industrial Networks AB Profinet card.
>
> Profinet is an industry technical standard for data communication over
> Industrial Ethernet, designed for collecting data from, and controlling,
> equipment in industrial systems, with a particular strength in delivering data
> under tight time constraints (on the order of 1ms or less).
>
> The profinet card itself is connected to the system via an industrial bus
> called 'anybus'.
>
> I have followed the bus driver/client driver pattern, and created an anybus
> bus driver, plus a client driver for the profinet card.
>
> In case this patch set gets (eventually) accepted, drivers for other anybus
> client cards may follow: flnet, cc-link, ...
>
> The anybus slot on the host is located on an 'anybus bridge', which is
> custom h/w designed by Arcx. Its driver is modeled as an mfd, which
> instantiates two anybus slots.

I highly recommend to look at my recent (for few month?) reviews -- they are
almost repeating each other.

Also check what we have under lib/ (hint: read linux/kernel.h for inline and
exported function helpers).

I might look at the patches later on if I would have some spare time (I
actually don't know why I'm in Cc list here).

>
> v1:
> first shot
>
> Sven Van Asbroeck (4):
> mfd: support the Arcx anybus bridge.
> dt-bindings: anybus-bridge: document devicetree binding.
> bus: support HMS Anybus-S bus.
> misc: support HMS Profinet IRT industrial controller.
>
> .../bindings/mfd/arcx,anybus-bridge.txt | 37 +
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> drivers/bus/Kconfig | 11 +
> drivers/bus/Makefile | 1 +
> drivers/bus/anybuss-host.c | 1301 +++++++++++++++++
> drivers/mfd/Kconfig | 11 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/anybus-bridge.c | 441 ++++++
> drivers/misc/Kconfig | 11 +
> drivers/misc/Makefile | 1 +
> drivers/misc/hms-profinet.c | 747 ++++++++++
> include/linux/anybuss-client.h | 100 ++
> include/linux/anybuss-host.h | 28 +
> include/uapi/linux/hms-common.h | 14 +
> include/uapi/linux/hms-profinet.h | 101 ++
> 15 files changed, 2806 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/arcx,anybus-bridge.txt
> create mode 100644 drivers/bus/anybuss-host.c
> create mode 100644 drivers/mfd/anybus-bridge.c
> create mode 100644 drivers/misc/hms-profinet.c
> create mode 100644 include/linux/anybuss-client.h
> create mode 100644 include/linux/anybuss-host.h
> create mode 100644 include/uapi/linux/hms-common.h
> create mode 100644 include/uapi/linux/hms-profinet.h
>
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2018-10-25 11:19    [W:0.144 / U:32.972 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site