lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm: fix call_kern.cocci warnings (fwd)
From
Date
will send a fix soon.


Thanks,

David


On 2018年10月25日 15:57, Koenig, Christian wrote:
> Am 25.10.18 um 09:51 schrieb Maarten Lankhorst:
>> Op 25-10-18 om 08:53 schreef Christian König:
>>> Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing):
>>>> Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
>>> NAK, GFP_ATOMIC should be avoided.
>>>
>>> The correct solution is to move the allocation out of the spinlock or drop the lock and reacquire.
>> Yeah +1. Especially in a case like this where it's obvious to prevent. :)
> Another possibility would to not allocate the dummy fence at all.
>
> E.g. we just need a global instance of that which is always signaled and
> has a reference count of +1.
>
> Christian.

\
 
 \ /
  Last update: 2018-10-25 10:32    [W:0.051 / U:112.644 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site