lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf trace beautify: Beautify flags of mount(2) and umount(2).
Em Mon, Oct 22, 2018 at 07:40:35PM -0700, Benjamin Peterson escreveu:
>
>
> On Wed, Oct 10, 2018, at 05:55, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Oct 09, 2018 at 08:52:26PM -0700, Benjamin Peterson escreveu:
> > > Hi Arnaldo,
> > > Did you get a chance to look at this again?

> > Thanks, for pinging me about it, will check.

> Will the main part of my patch manage to make the cut for 4.20?

The functionality will, but I'm implementing it differently, the model
you used to create the patch is being phased out, now we're unsing a
model that create tables from the header files where those flags are
defined, so that when a new one gets added, we get it included
automatically, please take a look at:

https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/trace.mount_flags

More specifically this one:

https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/trace.mount_flags&id=341628af5643adbaa78097d528f34b4b16aa908f

That will be used by one like tools/perf/trace/beauty/pkey_alloc.c, that
goes looking if the bits are set and if so, get the strings from the
table, etc.

In time pkey_alloc__scnprintf_access_rights() will be further
generalized, as all it needs is a strarray + the flags integer to
produce a simbolic or-ed flags string.

Sorry for taking so long, kept being sidetracked with other stuff...

- Arnaldo

\
 
 \ /
  Last update: 2018-10-24 22:19    [W:0.069 / U:5.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site