Messages in this thread | | | From | "Koenig, Christian" <> | Subject | Re: [PATCH] drm: fix call_kern.cocci warnings (fwd) | Date | Thu, 25 Oct 2018 07:57:07 +0000 |
| |
Am 25.10.18 um 09:51 schrieb Maarten Lankhorst: > Op 25-10-18 om 08:53 schreef Christian König: >> Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing): >>> Reviewed-by: Chunming Zhou <david1.zhou@amd.com> >> NAK, GFP_ATOMIC should be avoided. >> >> The correct solution is to move the allocation out of the spinlock or drop the lock and reacquire. > Yeah +1. Especially in a case like this where it's obvious to prevent. :)
Another possibility would to not allocate the dummy fence at all.
E.g. we just need a global instance of that which is always signaled and has a reference count of +1.
Christian.
| |