lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] staging: iio: ad2s1210: Switch to the gpio descriptor interface
On paź 24, 2018 20:20, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> Changes in v4:
> - Add spaces after { and before } in gpios[]
> initialization.
> - Check the correct pointer for error.
> - Align the dev_err msg to existing format in the code.
> Changes in v3:
> - Use a pointer to pointer for gpio_desc in
> struct ad2s1210_gpio as it will be used to
> modify a pointer.
> - Use dot notation to initialize the structure.
> - Use a pointer variable to avoid writing gpios[i].
> Changes in v2:
> - Use the spi_device struct embedded in st instead
> of passing it as an argument to ad2s1210_setup_gpios().
> - Use an array of structs to reduce redundant code in
> in ad2s1210_setup_gpios().
> - Remove ad2s1210_free_gpios() as devm API is being used.
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 92 ++++++++++++++-----------
> drivers/staging/iio/resolver/ad2s1210.h | 3 -
> 2 files changed, 50 insertions(+), 45 deletions(-)

Looks good to me.

Reviewed-by: Slawomir Stepien <sst@poczta.fm>

--
Slawomir Stepien

\
 
 \ /
  Last update: 2018-10-25 08:44    [W:1.994 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site