lkml.org 
[lkml]   [2018]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: axis-fifo: Fix line over 80 characters error
On Wed, Oct 24, 2018 at 05:05:53PM +0200, Aleksa Zdravkovic wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: line over 80 characters
> + (write_timeout >= 0) ? msecs_to_jiffies(write_timeout) :
>
> Signed-off-by: Aleksa Zdravkovic <alex.zdravkovic98@gmail.com>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index c18bf31f55b6..2f609712f507 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -482,10 +482,10 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> spin_lock_irq(&fifo->write_queue_lock);
> ret = wait_event_interruptible_lock_irq_timeout
> (fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> >= words_to_write,
> - fifo->write_queue_lock,
> - (write_timeout >= 0) ? msecs_to_jiffies(write_timeout) :
> + fifo->write_queue_lock,
> + (write_timeout >= 0) ? msecs_to_jiffies(write_timeout) :
> MAX_SCHEDULE_TIMEOUT);

The original was fine. Just leave it.

Checkpatch.pl is only useful if it improves the readability for humans.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-10-25 08:06    [W:0.052 / U:27.268 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site