Messages in this thread | | | Date | Thu, 25 Oct 2018 02:03:10 +0100 | From | Al Viro <> | Subject | Re: [PATCH] Change judgment len position |
| |
On Wed, Oct 24, 2018 at 11:28:11AM -0700, Joe Perches wrote: > On Wed, 2018-10-24 at 10:10 -0700, David Miller wrote: > > From: Wang Hai <wanghaifine@gmail.com> > > Date: Wed, 24 Oct 2018 23:47:29 +0800 > > > > > To determine whether len is less than zero, it should be put before > > > the function min_t, because the return value of min_t is not likely > > > to be less than zero. > [] > > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
[snip obviously broken patch]
> > You can't be serious? > > I'm not personally taken aback by this but > there is the new Code of > Conduct to consider. > > John McEnroe earned quite a bit of his > reputation as an 'enfant terrible' via a > similar statement. > > https://www.youtube.com/watch?v=t0hK1wyrrAU > > Perhaps a different word choice next time in > reply to submitters of ill-considered and/or > defective patches could be useful.
Please tell me we are being Poe'd...
| |