[lkml]   [2018]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] V3 init/main.c Enable watchdog_thresh control from kernel line
Hi Laurence,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux-sof-driver/master]
[also build test ERROR on v4.19 next-20181019]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

base: master
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

init/main.c: In function 'is_watchdog_thresh_setup':
>> init/main.c:1037:20: error: 'watchdog_thresh' undeclared (first use in this function); did you mean 'proc_watchdog_thresh'?
get_option(&str, &watchdog_thresh);
init/main.c:1037:20: note: each undeclared identifier is reported only once for each function it appears in

vim +1037 init/main.c

1034 static int __init
1035 is_watchdog_thresh_setup(char *str)
1036 {
> 1037 get_option(&str, &watchdog_thresh);
1038 return 1;
1039 }
1040 __setup("watchdog_thresh=", is_watchdog_thresh_setup);

0-DAY kernel test infrastructure Open Source Technology Center Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2018-10-24 20:25    [W:0.044 / U:33.168 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site