lkml.org 
[lkml]   [2018]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 4/5] hwmon: (ina3221) Make sure data is ready before reading
On Wed, Oct 24, 2018 at 09:10:35AM +0000, linux@roeck-us.net wrote:
> > @@ -150,6 +183,12 @@ static int ina3221_read_in(struct device *dev, u32
> > attr, int channel, long *val)
> > if (!ina3221_is_enabled(ina, channel))
> > return -ENODATA;
> >
> > + ret = ina3221_wait_for_data(ina);
> > + if (ret) {
> > + dev_err(dev, "Timed out at waiting for CVRF bit\n");
> > + return ret;
> > + }
>
> Thanks for explaining why we can't just blindly wait.
> However, I am concerned about this log message: If something is wrong
> with the chip, this will spam the kernel log. Can you drop the message
> here and below ? After all, the error will be reported to userspace,
> and a kernel log message should not be necessary.

Will do that.

Thanks
Nicolin

>
> Thanks,
> Guenter
>
> > +
> > ret = ina3221_read_value(ina, reg, &regval);
> > if (ret)
> > return ret;
> > @@ -189,6 +228,13 @@ static int ina3221_read_curr(struct device *dev,
> > u32 attr,
> > case hwmon_curr_input:
> > if (!ina3221_is_enabled(ina, channel))
> > return -ENODATA;
> > +
> > + ret = ina3221_wait_for_data(ina);
> > + if (ret) {
> > + dev_err(dev, "Timed out at waiting for CVRF bit\n");
> > + return ret;
> > + }
> > +
> > /* fall through */
> > case hwmon_curr_crit:
> > case hwmon_curr_max:
> > --
> > 2.17.1
>
>
>

\
 
 \ /
  Last update: 2018-10-24 19:55    [W:0.050 / U:17.484 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site