lkml.org 
[lkml]   [2018]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/7] leds: add TI LMU backlight driver
From
Date
Pavel

On 10/24/2018 04:14 AM, Pavel Machek wrote:
> On Tue 2018-10-23 12:06:17, Dan Murphy wrote:
>> From: Pavel Machek <pavel@ucw.cz>
>>
>> This adds backlight support for the following TI LMU
>> chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697.
>>
>> It controls LEDs on Droid 4
>> smartphone, including keyboard and screen backlights.
>>
>> Signed-off-by: Milo Kim <milo.kim@ti.com>
>> [add LED subsystem support for keyboard backlight and rework DT
>> binding according to Rob Herrings feedback]
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> [remove backlight subsystem support for now]
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> This is not correct way to sign off a patch.
>
> What is worse, this is very different from patch I submitted; this
> misses imporant parts while my patch was complete.
>
> I already submitted better patch for both the driver and device tree
> bindings. Can we go back and apply that?
>
> Then you can add your changes on top of that, if they actually make
> the situation better.

Thanks for this. I wanted to make sure not to loose any authorship or credit
in the commit. Actually removing Milo might help stop getting the bounce back
from the mail daemon.

I was using the RFC patch as my base https://lore.kernel.org/patchwork/patch/978995/

Which contains this sign off.

Dan

>
> Thanks,
> Pavel
>


--
------------------
Dan Murphy

\
 
 \ /
  Last update: 2018-10-24 14:28    [W:0.142 / U:15.804 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site