lkml.org 
[lkml]   [2018]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH] tpm: tpm_try_transmit() refactor error flow.
On Tue, 23 Oct 2018, Winkler, Tomas wrote:
> To the out label we jump after we are done with locality and cmd
> read() before we jump to locality 'locality'. We will need to add
> another variable to check If cmd_ready() was called or not in order to
> get rid of the extran label, it's not internally tracked so far.

I think this is fine.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

I tested this by assigning rc error code instead of requesting locality
in addition of testig unchanged code.

/Jarkko

\
 
 \ /
  Last update: 2018-10-24 10:59    [W:0.043 / U:1.600 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site