Messages in this thread | | | From | Leonardo Bras <> | Date | Tue, 23 Oct 2018 21:39:33 -0300 | Subject | Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning. |
| |
Hello Andy,
Yeah, it's much better. I will replace this part of the commit message. It will be fixed for v3.
Thank you!
On Mon, Oct 22, 2018 at 11:13 PM Andy Lutomirski <luto@amacapital.net> wrote:
> How about “The go32() and go64() functions has an argument and a local variable called ‘name’. Rename both to clarify the code and to fix a warning with -Wshadow.” > > Other than that, Acked-by: Andy Lutomirski <luto@kernel.org
| |